-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add manifest validation tool #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c0f9c6b to
85d48a7
Compare
9ee721e to
b1ed71b
Compare
Pull Request Test Coverage Report for Build 19034241365Details
💛 - Coveralls |
|
Looks good to me |
6ee3a30 to
0f4d9df
Compare
|
|
||
| const log = getLogger("utils:ui5Manifest"); | ||
|
|
||
| const LATEST_SCHEMA_URL = "https://raw.githubusercontent.com/SAP/ui5-manifest/main/schema.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered adding the @ui5/manifest npm package as a dependency instead of dynamically fetching the schema?
I guess the benefit of this approach is that the user will always validate against the latest version of the schema. But actually this could be a drawback as well since the MCP Server will become less deterministic.
A manifest.json that validates fine today might show errors tomorrow if a newly published schema makes respective changes. We should at least clarify with the maintainers of ui5-manifest whether pointing directly to the main branch (usually used for development) is fine here.
| }, async ({manifestPath}) => { | ||
| log.info(`Running manifest validation on ${manifestPath}...`); | ||
|
|
||
| const result = await runValidation(manifestPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like for the create tool, please normalize the path using the Context:
| const normalizedBasePath = await context.normalizePath(params.basePath); |
No description provided.