fixes show method crash for FEVectorBlock + additional show functions #45
Conversation
* fixes related to new TVector type for entries introduced in 1.2 * version bump and changelog (together with PR #45)
…rator, added calls of show functions to the tests
chmerdon
changed the title
test/test_febasis.jl
Outdated
|
|
||
| function test_vertex_values(EG, FEType, order) | ||
| qf = VertexRule(EG, order; T = Rational{Int}) | ||
| @show qf |
There was a problem hiding this comment.
I generally like the idea, but, nevertheless, the logs are pretty verbose now: https://github.com/WIAS-PDELib/ExtendableFEMBase.jl/actions/runs/16163910516/job/45621150705?pr=45#step:6:928
It may be better to test the show function directly with show(devnull, qf) which redirects the output into the void. Errors should be thrown as before, if something is not implemented correctly.
There was a problem hiding this comment.
One could also add a global variable target_stream = devnull in the runtests.jl. The user can set this to stdout if inspecting the output is needed. Opinions?
There was a problem hiding this comment.
and then use show(target_stream, obj) everywhere?
There was a problem hiding this comment.
Yes, or just show(devnull, obj) ... I am not sure whether a switch is any good or just creates confusion.
There was a problem hiding this comment.
After thinking for a few more seconds: no target_stream. If I want to inspect the output in the logs, I just remove the devnull
There was a problem hiding this comment.
Ok, then I will use show(devnull, obj)
@show of FEVectorBlock was not working