upload_test_binaries clears testsuite before downloading artifact #116
Conversation
| @@ -164,6 +164,6 @@ jobs: | |||
| - name: Publish changes to consumer branch | |||
| shell: bash | |||
| run: | | |||
| git add tests/${{ matrix.suite }}/testsuite/*.wasm -f | |||
| git diff --quiet --cached || git commit -m "Update test binaries for ${{ matrix.suite }} test suite" | |||
| git add -f tests/${{ matrix.suite }}/testsuite | |||
There was a problem hiding this comment.
could you doublecheck that testsuite folder (which is a build folder only now) doesn't have any build leftovers that should not be checked in?
There was a problem hiding this comment.
The testsuite folder will be build-only -- its contents will be populated exclusively by the build.py scripts, not by the language-specific toolchains -- but until #112 et al are merged, these dirs are still managed by git and have some source files in them. However that's fine, there's no build artifacts.
To verify, you can look at the checks for this PR: https://github.com/WebAssembly/wasi-testsuite/actions/runs/17126318193. If you open the "Build C tests (ubuntu-latest)" jobs, you can click through to the "upload precompiled tests" action, which gives you a link to the artifact, in this case https://github.com/WebAssembly/wasi-testsuite/actions/runs/17126318193/artifacts/3818409902. Its contents are the contents of tests/c/testsuite from main git, plus the wasm files. In future its content will just be the wasm files, json files, and the test directory. Same for the Assemblyscript and Rust tests.
The previous state was that the build_assemblyscript, build_c, and
build_rust workflows upload tests/*/testsuite as an artifact, and then
upload_test_binaries runs once for each of {rust,assemblyscript,c},
removing any wasm file in tests/*lang*/testsuite, downloading the
artifact, unpacking it to tests/*lang*/testsuite, and adding and
committing to prod/testsuite/base if any file differed.
This PR implements a more simple and robust approach, which is to just
have upload_test_binaries remove tests/*lang*/testsuite before unpacking
the artifact.
wingo
force-pushed
the
simplify-upload-test-binaries
branch
from
c6b9717 to
3b0b6fd
Compare
The previous state was that the build_assemblyscript, build_c, and build_rust workflows upload tests/*/testsuite as an artifact, and then upload_test_binaries runs once for each of {rust,assemblyscript,c}, removing any wasm file in tests/lang/testsuite, downloading the artifact, unpacking it to tests/lang/testsuite, and adding and committing to prod/testsuite/base if any file differed.
This PR implements a more simple and robust approach, which is to just have upload_test_binaries remove tests/lang/testsuite before unpacking the artifact.