Skip to content

upload_test_binaries clears testsuite before downloading artifact #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
+3 −3
Merged

upload_test_binaries clears testsuite before downloading artifact #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/compile-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
run: git merge ${{ github.sha }}

- name: Remove existing binaries
run: git rm --ignore-unmatch tests/${{ matrix.suite }}/testsuite/*.wasm
run: rm -rf tests/${{ matrix.suite }}/testsuite

- name: Download ${{ matrix.suite }} test binaries
uses: actions/download-artifact@v4
Expand All @@ -164,6 +164,6 @@ jobs:
- name: Publish changes to consumer branch
shell: bash
run: |
git add tests/${{ matrix.suite }}/testsuite/*.wasm -f
git diff --quiet --cached || git commit -m "Update test binaries for ${{ matrix.suite }} test suite"
git add -f tests/${{ matrix.suite }}/testsuite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you doublecheck that testsuite folder (which is a build folder only now) doesn't have any build leftovers that should not be checked in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testsuite folder will be build-only -- its contents will be populated exclusively by the build.py scripts, not by the language-specific toolchains -- but until #112 et al are merged, these dirs are still managed by git and have some source files in them. However that's fine, there's no build artifacts.

To verify, you can look at the checks for this PR: https://github.com/WebAssembly/wasi-testsuite/actions/runs/17126318193. If you open the "Build C tests (ubuntu-latest)" jobs, you can click through to the "upload precompiled tests" action, which gives you a link to the artifact, in this case https://github.com/WebAssembly/wasi-testsuite/actions/runs/17126318193/artifacts/3818409902. Its contents are the contents of tests/c/testsuite from main git, plus the wasm files. In future its content will just be the wasm files, json files, and the test directory. Same for the Assemblyscript and Rust tests.

git diff --quiet || git commit -m "Update test binaries for ${{ matrix.suite }} test suite"
git push
Loading