Skip to content

Conversation

@iuhilnehc-ynos
Copy link

Signed-off-by: Chen Lihui [email protected]

@iuhilnehc-ynos
Copy link
Author

to fix ros2/ros2_documentation#2944

@iuhilnehc-ynos
Copy link
Author

close it as it has a potential issue if there defines a function named complete.

@iuhilnehc-ynos
Copy link
Author

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

@mjbogusz
Copy link

Cross-ref ros2/ros2cli#534

close it as it has a potential issue if there defines a function named complete.

This behavior is unexpected even if using the bash, so I'll continue to push this PR.

See ros2/ros2cli#750 for an approach that doesn't collide with a complete function... But I'm not sure whether it's 100% correct either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants