Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 11, 2025

Checklist

  • passed schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

For reference: @djmorvay

Summary by CodeRabbit

  • New Features
    • Added support for the LUXH743NDAA board, enabling full operation on this hardware.
    • Enabled key peripherals: accelerometer, gyroscope, barometer, magnetometer, GPS, SD card, onboard flash, OSD, beeper, LEDs, motors, and servos.
    • Configured UART, I2C, SPI, ADC, camera and power controls for sensors and accessories.
    • Optimized timer and DMA mappings for reliable motor/servo outputs and sensor performance.
    • Set sensible defaults for metering, gyro behavior, and camera switching.

@haslinghuis haslinghuis self-assigned this Oct 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 11, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new board configuration header for LUXH743NDAA that declares MCU/board identifiers, enabled sensors/peripherals, pin and timer channel mappings (TIMER_PIN_MAPPING), DMA options, bus instances (UART/I2C/SPI), and default device settings.

Changes

Cohort / File(s) Summary of modifications
New STM32H743 board config
configs/LUXH743NDAA/config.h
Added a device-specific configuration header: sets FC_TARGET_MCU, board/manufacturer IDs, enables sensors/peripherals (accel, gyro, baro, flash, SD, MAX7456, mag, GPS), defines beeper/LED/RX/UART/I2C/SPI/ADC pins and inversion flags, declares TIMER_PIN_MAPPING for motor/servo timer-channel assignments and DMA optimization macros, configures I2C/gyro instances and alignment, default meter sources/scales, and camera/power PINIO controls.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ot0tot
  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only contains the checklist section from the template and lacks an overview of the change, hardware compliance details, references to design guidelines, and any contextual information about the new board configuration, so it does not adhere to the repository’s required description structure. Please expand the description by filling in the template’s sections with a summary of the added LUXH743NDAA configuration, confirm compliance with manufacturer guidelines and testing status, provide schematic references and any additional context required by the repository’s description template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Add LUXH743NDAA” succinctly describes the primary intent of the changeset, which is to introduce the configuration for the LUXH743NDAA board, making it clear and directly related to the main addition in this pull request. It is concise and informative for anyone scanning the history to understand the core change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant