Skip to content

Conversation

VitalyAnkh
Copy link
Contributor

@VitalyAnkh VitalyAnkh commented May 7, 2025

Objective

Solution

  • Replace async-std with futures-timer.

Testing

CI

@VitalyAnkh
Copy link
Contributor Author

VitalyAnkh commented May 7, 2025

I’d prefer to list async-io as a direct dependency of this example rather than of Bevy itself. Although Bevy adds async-std as dev-dependency, it appears to be used only here. What do you think?

@alice-i-cecile
Copy link
Member

I'm okay with that but I had no idea that was possible. Can you make the change to demonstrate?

@VitalyAnkh
Copy link
Contributor Author

The plan is to package the async‑compute examples like the mobile example then we could specify dependencies in Cargo.toml (

), but since dev-dependencies don’t affect runtime, the current arrangement works fine.

This should be ready for merging now.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels May 9, 2025
@janhohenheim janhohenheim added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 17, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 21, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2025
@alice-i-cecile
Copy link
Member

@VitalyAnkh CI is failing due to web build failures, can you please take a look?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 26, 2025
@VitalyAnkh
Copy link
Contributor Author

Sure, I'm looking into the CI failures.

@VitalyAnkh
Copy link
Contributor Author

I'm confused, the CI passed without changes but merging main: https://github.com/bevyengine/bevy/actions/runs/17226805596/job/48873622621?pr=19113#logs. @alice-i-cecile Alice, could you take a look?

@james7132
Copy link
Member

Looks like it was a transient failure.

@james7132 james7132 added this pull request to the merge queue Aug 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2025
@VitalyAnkh
Copy link
Contributor Author

run-examples-on-wasm still fails. I need to solve the problem.

@VitalyAnkh
Copy link
Contributor Author

errno, which async-io depends, doesn't support target wasm32-unknown-unknown: lambda-fairy/rust-errno@a9bd71e.

@VitalyAnkh
Copy link
Contributor Author

Since async-io doesn't support Timer on wasm target and we only need a Timer here, I'm going to use https://github.com/async-rs/futures-timer instead.

@VitalyAnkh VitalyAnkh changed the title replace async-std with async-io examples: migrate async sleep to futures-timer; drop async-std Aug 26, 2025
@VitalyAnkh
Copy link
Contributor Author

This is ready to go now.

@VitalyAnkh VitalyAnkh added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 26, 2025
@james7132 james7132 added this pull request to the merge queue Aug 27, 2025
Merged via the queue into bevyengine:main with commit 805bf13 Aug 27, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example async_compute.rs uses the discontinued async-std
4 participants