-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
examples: migrate async sleep to futures-timer
; drop async-std
#19113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: migrate async sleep to futures-timer
; drop async-std
#19113
Conversation
I’d prefer to list |
I'm okay with that but I had no idea that was possible. Can you make the change to demonstrate? |
The plan is to package the async‑compute examples like the mobile example then we could specify dependencies in
This should be ready for merging now. |
@VitalyAnkh CI is failing due to web build failures, can you please take a look? |
Sure, I'm looking into the CI failures. |
I'm confused, the CI passed without changes but merging main: https://github.com/bevyengine/bevy/actions/runs/17226805596/job/48873622621?pr=19113#logs. @alice-i-cecile Alice, could you take a look? |
Looks like it was a transient failure. |
run-examples-on-wasm still fails. I need to solve the problem. |
errno, which async-io depends, doesn't support target wasm32-unknown-unknown: lambda-fairy/rust-errno@a9bd71e. |
Since async-io doesn't support Timer on wasm target and we only need a Timer here, I'm going to use https://github.com/async-rs/futures-timer instead. |
async-std
with async-io
futures-timer
; drop async-std
This is ready to go now. |
Objective
Solution
async-std
withfutures-timer
.Testing
CI