Skip to content

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Aug 25, 2025

Objective

  • Add a constructor to WinitSettings for the continuous update mode used by the stress tests.

Solution

  • Add the constructor.

…as fast as possible regardless of whether its window has focus.
@ickshonpe ickshonpe requested a review from mockersf August 25, 2025 17:05
@ickshonpe ickshonpe changed the title Add a WinitSettings::continuous constructor, set all stress tests to use continuous update modes Add a WinitSettings::continuous constructor Aug 25, 2025
@james7132 james7132 added A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 25, 2025
@ickshonpe ickshonpe added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 25, 2025
@mockersf
Copy link
Member

mockersf commented Aug 25, 2025

we wanted to avoid having this kind of things in Bevy main... the idea that floated for a while was to do a common rust file in the stress tests folder that would be imported by all and do the setup correctly

edit: I somehow reviewed the commit before the previous suggestion were it was mentioning stress tests, it's better now 🙂

@ickshonpe
Copy link
Contributor Author

ickshonpe commented Aug 27, 2025

we wanted to avoid having this kind of things in Bevy main... the idea that floated for a while was to do a common rust file in the stress tests folder that would be imported by all and do the setup correctly

edit: I somehow reviewed the commit before the previous suggestion were it was mentioning stress tests, it's better now 🙂

Yeah initially I wrote it that way as well, then somehow circled around and thought myself into to adding the bit about stress tests 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants