Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 23, 2025

@DrahtBot
Copy link

DrahtBot commented Aug 23, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

hebasto added a commit to hebasto/bitcoin-core-nightly that referenced this pull request Aug 23, 2025
hebasto added a commit to hebasto/bitcoin-core-nightly that referenced this pull request Aug 23, 2025
@ryanofsky
Copy link
Collaborator

Errors all appear to be undefined reference to 'kj::getCaughtExceptionAsKj()' linker errors

@hebasto hebasto closed this Aug 23, 2025
@hebasto hebasto reopened this Aug 23, 2025
@ryanofsky
Copy link
Collaborator

I noticed getCaughtExceptionAsKj doesn't seem to be defined if KJ_NO_EXCEPTIONS is defined. Doesn't look like netbsd is defining that though https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/capnproto/

@ryanofsky ryanofsky closed this Aug 23, 2025
@ryanofsky ryanofsky reopened this Aug 23, 2025
@Sjors
Copy link
Member

Sjors commented Sep 5, 2025

Maybe rebase after #197 for easier review?

Add `pkg-config` package
@hebasto
Copy link
Member Author

hebasto commented Sep 5, 2025

Maybe rebase after #197 for easier review?

Sure! Rebased.

@ryanofsky
Copy link
Collaborator

Assuming the netbsd job still fails, I guess there are different directions we may go with this issue:

  • If it's possible to fix this with a change in libmultiprocess that would be ideal.
  • If that's not possible, then maybe netbsd job could install from capnproto from source and we could report an issue to netbsd.
  • If installing capnproto from source doesn't work, this will require a fix in capnproto.

And regardless of these, we may want to add a try_compile test and error with suggested workarounds along the lines of #205

@hebasto
Copy link
Member Author

hebasto commented Sep 5, 2025

Assuming the netbsd job still fails, I guess there are different directions we may go with this issue:

  • If it's possible to fix this with a change in libmultiprocess that would be ideal.

  • If that's not possible, then maybe netbsd job could install from capnproto from source and we could report an issue to netbsd.

  • If installing capnproto from source doesn't work, this will require a fix in capnproto.

And regardless of these, we may want to add a try_compile test and error with suggested workarounds along the lines of #205

FWIW, build with depends succeeds: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/17482518540/job/49655572035.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants