ci: Add freebsd and macos build #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
force-pushed
the
2508-freebsd
branch
2 times, most recently
from
553efe8 to
a504a4c
Compare
hebasto
reviewed
Aug 29, 2025
hebasto
reviewed
Aug 29, 2025
|
Concept ACK This may also help debug why (so far) I haven't been able to run the nix based tests on macOS. |
The CI task added here isn't using nix on macos. It is certainly possible to do so, see https://github.com/maflcko/libmultiprocess/actions/runs/17243581016/job/48927248082 / e8dc12d. However:
No strong opinion, but happy to adjust, if there are reasons to do so. |
That's probably true. It seems useful to test on macOS without nix. |
hebasto
reviewed
Sep 2, 2025
Also, remove unused python from install.
maflcko
force-pushed
the
2508-freebsd
branch
from
a504a4c to
fa1ac30
Compare
hebasto
approved these changes
Sep 2, 2025
Sjors
reviewed
Sep 4, 2025
|
|
||
| - name: Run CI script | ||
| run: | | ||
| CI_CONFIG="ci/configs/macos.bash" bash ci/scripts/ci.sh |
There was a problem hiding this comment.
I tested that this also works locally on macOS.
|
ACK fa1ac30 |
Draft
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 5, 2025
…f2ecc1 13424cf2ecc1 Merge bitcoin-core/libmultiprocess#205: cmake: check for Cap'n Proto / Clang / C++20 incompatibility 72dce118649b Merge bitcoin-core/libmultiprocess#200: event loop: add LogOptions struct and reduce the log size 85003409f964 eventloop: add `LogOptions` struct 657d80622f81 cmake: capnproto pkg missing helpful error d314057775a5 cmake: check for Cap'n Proto / Clang / C++20 incompatibility 878e84dc3030 Merge bitcoin-core/libmultiprocess#203: cmake: search capnproto in package mode only 1a85da5873c2 Merge bitcoin-core/libmultiprocess#202: doc: correct the build instructions for the example df01873e1ecb Merge bitcoin-core/libmultiprocess#197: ci: Add freebsd and macos build 3bee07ab3367 cmake: search capnproto in package mode only b6d3dc44194c doc: correct the build instructions for example fa1ac3000055 ci: Add macos and freebsd task git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: 13424cf2ecc1e5eadc85556cf1f4c65e915f702a
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Sep 8, 2025
a334bbe Squashed 'src/ipc/libmultiprocess/' changes from 1b8d4a6f1e54..13424cf2ecc1 (Ryan Ofsky) Pull request description: Includes: - bitcoin-core/libmultiprocess#197 - bitcoin-core/libmultiprocess#202 - bitcoin-core/libmultiprocess#203 - bitcoin-core/libmultiprocess#200 - bitcoin-core/libmultiprocess#205 These changes should give better feedback when there are build errors, and also make IPC logs more readable. The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh) ACKs for top commit: Sjors: ACK a4ee70e Tree-SHA512: ddddd0ed44522ade98a5b94f44b57210794d64f8c378a00438082b8c377f41e9b86c0c5ed29add45472549758f7478ab220af8e268b90b30f57a236c639497d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be harmless to add and may be useful