Skip to content

Conversation

@EranBoudjnah
Copy link

🎟️ Tracking

#4913

📔 Objective

Allow users to use no separator in passphrases.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2025

CLA assistant check
All committers have signed the CLA.

@EranBoudjnah
Copy link
Author

This should be updated too:

data class PassphraseGeneratorRequest (
    /**
     * Number of words in the generated passphrase.
     * This value must be between 3 and 20.
     */
    val `numWords`: kotlin.UByte, 
    /**
     * Character separator between words in the generated passphrase. The value cannot be empty.
     */
    val `wordSeparator`: kotlin.String, 
    /**
     * When set to true, capitalize the first letter of each word in the generated passphrase.
     */
    val `capitalize`: kotlin.Boolean, 
    /**
     * When set to true, include a number at the end of one of the words in the generated
     * passphrase.
     */
    val `includeNumber`: kotlin.Boolean
) {
    
    companion object
}

@EranBoudjnah EranBoudjnah force-pushed the PM-19476-default-to-no-word-separator branch from b33f24f to 4d04549 Compare June 9, 2025 16:28
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-22523
Link: https://bitwarden.atlassian.net/browse/PM-22523

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title PM-19476: Changed default passphrase word separator to empty string. [PM-22523] PM-19476: Changed default passphrase word separator to empty string. Jun 9, 2025
@EranBoudjnah EranBoudjnah force-pushed the PM-19476-default-to-no-word-separator branch from 4d04549 to f55fa2b Compare June 9, 2025 21:54
@EranBoudjnah EranBoudjnah force-pushed the PM-19476-default-to-no-word-separator branch from f55fa2b to d1bbe59 Compare June 19, 2025 15:12
@djsmith85 djsmith85 linked an issue Jun 23, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty word separator in passphrase generator still separates with space

4 participants