Skip to content

[PM-22523] PM-19476: Changed default passphrase word separator to empty string. #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PM-22523] PM-19476: Changed default passphrase word separator to empty string. #5334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class MasterPasswordGeneratorViewModel @Inject constructor(
val optionsWordCount = options?.numWords ?: DEFAULT_WORD_COUNT
return PassphraseGeneratorRequest(
numWords = max(optionsWordCount, DEFAULT_WORD_COUNT).toUByte(),
wordSeparator = options?.wordSeparator ?: DEFAULT_SEPARATOR,
wordSeparator = options?.wordSeparator.orEmpty(),
capitalize = policy.requireUpper == true,
includeNumber = policy.requireNumbers == true,
)
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ class GeneratorViewModel @Inject constructor(
private suspend fun generatePassphrase(passphrase: GeneratorState.MainType.Passphrase) {
val request = PassphraseGeneratorRequest(
numWords = passphrase.numWords.toUByte(),
wordSeparator = passphrase.wordSeparator?.toString() ?: " ",
wordSeparator = passphrase.wordSeparator?.toString().orEmpty(),
capitalize = passphrase.capitalize,
includeNumber = passphrase.includeNumber,
)
Expand Down
Loading