-
Notifications
You must be signed in to change notification settings - Fork 19
Cleaned up language in Specifications #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brianthered
wants to merge
1
commit into
c2pa-org:main
Choose a base branch
from
Brianthered:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -449,7 +449,7 @@ <h3 id="_scope"><a class="anchor" href="#_scope"></a>1.2. Scope</h3> | |
</div> | ||
<div class="quoteblock"> | ||
<blockquote> | ||
C2PA specifications SHOULD NOT provide value judgments about whether a given set of provenance data is 'good' or 'bad,' merely whether the assertions included within can be validated as associated with the underlying asset, correctly formed, and free from tampering. | ||
C2PA specifications SHOULD NOT provide value judgments about whether a given set of provenance data is 'good' or 'bad'. The assertions can be: validated as associated with the underlying asset, can be correctly formed, and are free from tampering. | ||
</blockquote> | ||
</div> | ||
</td> | ||
|
@@ -760,7 +760,7 @@ <h4 id="_content_credential"><a class="anchor" href="#_content_credential"></a>2 | |
<p>This is the preferred, non-technical, term for a <a href="#_c2pa_manifest">C2PA Manifest</a>. The <a href="#_c2pa_manifest_store">C2PA Manifest Store</a> therefore represents the Content Credentials of an asset.</p> | ||
</div> | ||
<div class="paragraph"> | ||
<p>Content Credentials also refers to the overall C2PA technology, and is therefore essentially treated as a plural noun. If a <a href="#_c2pa_manifest">C2PA Manifest</a> is a Content Credential, then multiple <a href="#_c2pa_manifest">C2PA Manifest</a> or the broader, universal concept is Content Credentials.</p> | ||
<p>Content Credentials can also refer to the overall C2PA technology. If a <a href="#_c2pa_manifest">C2PA Manifest</a> is a Content Credential, then multiple <a href="#_c2pa_manifest">C2PA Manifests</a> or the universally aggreated concepts are Content Credentials.</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Content Credentials ALWAYS refers to the technology - can implies a choice. Also, the grammar is important about the plural noun What are your concerns with this text? |
||
</div> | ||
</div> | ||
<div class="sect3"> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the current text - what is the concern here?