Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Preparation for #1114.

To use trusted publishers, we have to be on Node 24.5 or above.

I've also replaced engines in package.json and .nvrmc file with .node-version file, as (according to my research) it's the most widely-supported configuration file across various Node version managers. Note that publishable packages still have engines.node set to >=20, because we want to be compatible with older versions, but use the latest version for development.

@matejchalk matejchalk self-assigned this Sep 22, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🦾 CI/CD Continuous integration and deployment 🛠️ tooling labels Sep 22, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 22, 2025

View your CI Pipeline Execution ↗ for commit 7a5dfeb

Command Status Duration Result
nx affected -t e2e-test --parallel=1 ❌ Failed 12m 15s View ↗
nx affected -t int-test --parallel=3 ✅ Succeeded 1s View ↗
nx affected -t lint --parallel=3 ✅ Succeeded 56s View ↗
nx affected -t unit-test --parallel=3 ✅ Succeeded 1s View ↗
nx run-many --target=build --parallel=3 ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-22 14:49:19 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 22, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1116

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1116

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1116

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1116

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1116

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1116

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1116

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1116

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1116

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1116

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1116

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1116

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1116

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1116

commit: 7a5dfeb

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 068d49e with previous commit 3b5db5b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 35 🔴 42 ↑ +7.3
Code coverage 🟡 90 🟡 90 ↑ +0.2
Documentation 🔴 25 🔴 24 ↓ −0.2
Security 🟡 56 🟡 56
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 8 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 35 🔴 42 ↑ +7.3
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.2
JSDoc coverage Documentation coverage 🔴 25 🔴 24 ↓ −0.2

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,676 KiB 🟩 Total size was 2,027 KiB ↓ −24.2 %
Lighthouse Speed Index 🟥 6.3 s 🟨 5.0 s ↓ −20.1 %
Lighthouse Total Blocking Time 🟥 2,840 ms 🟥 1,290 ms ↓ −54.8 %
Lighthouse Time to Interactive 🟥 16.8 s 🟥 12.4 s ↓ −25.9 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 2.8 s ↓ −6.1 %
Lighthouse Max Potential First Input Delay 🟥 1,080 ms 🟥 780 ms ↓ −27.2 %
JSDoc coverage Functions coverage 🟥 521 undocumented functions 🟥 521 undocumented functions  +0 %
Code coverage Function coverage 🟩 92.1 % 🟩 92.5 % ↑ +0.4 %
JSDoc coverage Types coverage 🟥 243 undocumented types 🟥 241 undocumented types ↓ −0.8 %
Code coverage Branch coverage 🟨 85.6 % 🟨 85.5 % ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −25.9 %
Lighthouse Minimizes main-thread work 🟥 11.2 s 🟥 9.7 s ↓ −14.1 %
Lighthouse JavaScript execution time 🟥 5.2 s 🟥 3.8 s ↓ −28.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 31 resources found ↑ +0.2 %
Lighthouse Server Backend Latencies 🟩 970 ms 🟩 1,450 ms ↑ +50.4 %
Lighthouse Largest Contentful Paint 🟥 10.9 s 🟥 10.7 s ↓ −2.2 %
Lighthouse Initial server response time was short 🟩 Root document took 590 ms 🟩 Root document took 370 ms ↓ −36.8 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 102 KiB ↓ −23 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 602 KiB 🟥 Potential savings of 155 KiB ↓ −14.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,288 elements 🟥 2,306 elements ↑ +0.8 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 97 KiB 🟥 Potential savings of 98 KiB ↑ +3.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↓ −29 %
JS Packages Outdated NPM dev dependencies. 🟨 56 outdated package versions (22 major, 28 minor, 6 patch) 🟨 58 outdated package versions (22 major, 28 minor, 8 patch) ↑ +3.6 %
Code coverage Line coverage 🟨 86.3 % 🟨 86.3 % ↑ +0.1 %

586 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review September 22, 2025 14:42
@matejchalk matejchalk merged commit 3a1e2f6 into main Sep 22, 2025
19 of 20 checks passed
@matejchalk matejchalk deleted the node-24 branch September 22, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦾 CI/CD Continuous integration and deployment 📖 Project documentation improvements or additions to the project documentation 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants