Merge 3d animation node #10025
Open
Merge 3d animation node #10025
+19
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
requested review from
Kosinkadink,
christian-byrne,
guill,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
|
Lmk when the frontend PR is ready/everything is ready to go, and then we can merge both |
yeah, this is how we work before, and I watch when FE is included in Core, then I will ping Christian to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BE change for FE PR https://github.com/Comfy-Org/ComfyUI_frontend/pull/5765/files,
Merge 3d animation node into 3d node, and remove lineart output for now (as animation doens't support it)