Makefile improvement #1101
Merged
Makefile improvement #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parrot7483
requested review from
W95Psp and
maximebuyse
and removed request for
jschneider-bensch
Parrot7483
force-pushed
the
makefile-improvement
branch
from
0256eb3 to
eed238b
Compare
W95Psp
approved these changes
Aug 19, 2025
|
My approval is worthless on libcrux I think, you should ask review from i.e. @jschneider-bensch |
I just realized that as well. |
franziskuskiefer
approved these changes
Aug 20, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes two things in the default Makefile.
FINDLIBS_OUTPUT ?=makes it possible to disable automatic import of modules in a makefile using the default one.cleanto run the build target and remove more auxiliary filesPR #1092 is based on these two commits.