Refactor integration tests #4208
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
integration_tests
and some tweaks to_tests
and other tests:integration_tests
were not fully end to end, they wrote their ownbuild.dart
script which called thebuild_runner
run
method bypassing the build_runner bootstrap code; this is the main reason for doing the rewrite now as this is awkward for the bootstrap rewrite currently in progress. Make them all usdart run build_runner
so they are actually end to end._tests
that are covered inintegration_tests
:Re-snapshots if there is no asset graph
,exception_handling_test.dart
help_test
, this is testing configuration and not really worth an e2e test.build_script_generate_test
intointegration_tests
as they are e2e testsbuild_integration_test.dart
is replaced by equivalent tests, except: "checking for existing outputs works with deleted intermediate outputs" is delete, it's covered sufficiently by smaller testssymlinks_test
is deleted because the results tested are what happens anyway with symlinked files, there is no supporting implementationserve
now check invalidation withwatch
instead becausewatch
is much more widely used and the implementation is the sameUpdate the CI configs:
dev
, there doesn't seem to be a lot of value in running on different SDKsFurther follow-up work:
_test
e2e tests can be replaced byintegration_tests
, mostly this looks like covering web builds