Skip to content

Refactor integration tests #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor integration tests #4208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,972 changes: 327 additions & 1,645 deletions .github/workflows/dart.yml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion _benchmark/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
sdk:
- pubspec
- dev

os:
- linux

stages:
- analyze_and_format:
- format
- analyze: --fatal-infos .
19 changes: 0 additions & 19 deletions _test/build.throws.yaml
View file
Open in desktop

This file was deleted.

13 changes: 5 additions & 8 deletions _test/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
sdk:
- main
- dev

os:
- linux
- windows

stages:
- analyze_and_format:
- format
- analyze: --fatal-infos .
os: linux
- unit_test:
- command: dart run build_runner test -- -p chrome --test-randomize-ordering-seed=random
os:
- linux
- windows
# TODO(https://github.com/dart-lang/build/issues/3423): restore this on windows
- command: dart run build_runner test -- -p vm test/configurable_uri_test.dart --test-randomize-ordering-seed=random
os: linux
Expand All @@ -27,8 +29,3 @@ stages:
os: windows
- test: --total-shards 3 --shard-index 2 --test-randomize-ordering-seed=random
os: windows
# This stage is configured to only run for scheduled builds (see mono_repo.yaml)
- e2e_test_cron:
- test:
sdk:
- be/raw/latest
20 changes: 0 additions & 20 deletions _test/test/build_integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ library;

import 'dart:io';

import 'package:build_runner/src/internal.dart';
import 'package:path/path.dart' as p;
import 'package:test/test.dart';

Expand Down Expand Up @@ -127,25 +126,6 @@ void main() {
expect(dartSource.existsSync(), true);
});

test('Re-snapshots if there is no asset graph', () async {
final assetGraph = assetGraphPathFor(scriptKernelLocation);
await File(assetGraph).delete();

final nextBuild = await runBuild();
expect(
(nextBuild.stdout as String).split('\n'),
containsAllInOrder([
contains('Generating the build script'),
contains('Compiling the build script.'),
contains('Creating the asset graph.'),
contains(
'Building, full build because there is no valid asset graph.',
),
contains(BuildLog.successPattern),
]),
);
});

test('incremental build after resolve missing import', () async {
final dartSource = File(p.join('lib', 'app.dart'));
dartSource.writeAsStringSync(
Expand Down
35 changes: 0 additions & 35 deletions _test/test/exception_handling_test.dart
View file
Open in desktop

This file was deleted.

87 changes: 0 additions & 87 deletions _test/test/help_test.dart
View file
Open in desktop

This file was deleted.

15 changes: 4 additions & 11 deletions build/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
sdk:
- pubspec
- dev

os:
- linux

stages:
- analyze_and_format:
- format
- analyze: --fatal-infos .
- format:
sdk:
- dev
- unit_test:
- test: --test-randomize-ordering-seed=random
os:
- linux
- windows

cache:
directories:
- .dart_tool/build
15 changes: 5 additions & 10 deletions build_config/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
sdk:
- dev

os:
- linux

stages:
- analyze_and_format:
- group:
- format
- analyze: --fatal-infos .
- format
- analyze: --fatal-infos .
- unit_test:
- test: --test-randomize-ordering-seed=random
os:
- linux
- windows

cache:
directories:
- .dart_tool/build
11 changes: 5 additions & 6 deletions build_daemon/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
sdk:
- dev
- pubspec

os:
- linux

stages:
- analyze_and_format:
- group:
- format
- analyze: --fatal-infos .
sdk:
- dev
- format
- analyze: --fatal-infos .
- unit_test:
- test: --test-randomize-ordering-seed=random
os:
Expand Down
17 changes: 6 additions & 11 deletions build_modules/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
sdk:
- main
- dev

os:
- linux

stages:
- analyze_and_format:
- group:
- format
- analyze: --fatal-infos .
- format
- analyze: --fatal-infos .
- unit_test:
- test: -P presubmit --test-randomize-ordering-seed=random
os:
- linux
- windows

cache:
directories:
- .dart_tool/build
4 changes: 3 additions & 1 deletion build_runner/dart_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ presets:
include_tags: experiments

tags:
integration:
slow:
timeout: 16x
integration:
timeout: 4x
experiments:
skip: 'Only ran if `-P experiments` is passed'
presets: {experiments: {skip: false}}
32 changes: 16 additions & 16 deletions build_runner/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
sdk:
- pubspec
- dev

os:
- linux

stages:
- analyze_and_format:
- group:
- format
- analyze: --fatal-infos .
- format
- analyze: --fatal-infos .
- unit_test:
- test: -x integration --test-randomize-ordering-seed=random
- test: -x integration -x slow --test-randomize-ordering-seed=random
- test: -P experiments --test-randomize-ordering-seed=random
sdk:
- dev
- test: -t integration --test-randomize-ordering-seed=random
os:
- linux
- windows
- leak_check:
- group:
- command: ../tool/leak_check.sh
sdk: dev
- command: ../tool/leak_check.sh
- e2e_test:
# TODO: enable stack trace chaining https://github.com/dart-lang/build/issues/2894
- test: -t integration --total-shards 5 --shard-index 0 --test-randomize-ordering-seed=random --no-chain-stack-traces -j 1
- test: -t integration --total-shards 5 --shard-index 1 --test-randomize-ordering-seed=random --no-chain-stack-traces -j 1
- test: -t integration --total-shards 5 --shard-index 2 --test-randomize-ordering-seed=random --no-chain-stack-traces -j 1
- test: -t integration --total-shards 5 --shard-index 3 --test-randomize-ordering-seed=random --no-chain-stack-traces -j 1
- test: -t integration --total-shards 5 --shard-index 4 --test-randomize-ordering-seed=random --no-chain-stack-traces -j 1
- test: -t slow --total-shards 5 --shard-index 0 --test-randomize-ordering-seed=random -j 1
- test: -t slow --total-shards 5 --shard-index 1 --test-randomize-ordering-seed=random -j 1
- test: -t slow --total-shards 5 --shard-index 2 --test-randomize-ordering-seed=random -j 1
- test: -t slow --total-shards 5 --shard-index 3 --test-randomize-ordering-seed=random -j 1
- test: -t slow --total-shards 5 --shard-index 4 --test-randomize-ordering-seed=random -j 1
Loading
Loading