-
Couldn't load subscription status.
- Fork 14
feat: auto login #5636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto login #5636
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/MainSceneLoader.cs # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
|
Testing in progress Test on Windows Auto-login test.windows.PR-5636.windows.mp4Player (1).log After auto-login, log out, login with a different user and the auto-login corresponds to the user last logged in test.windows.PR-5636.windows.-.switch.user.mp4Switch user - choose "Use a different account" test.windows.PR-5636.windows.-.use.a.different.account.mp4**Test in Mac ** Auto login auto.login.mac.mp4Switch to another account and auto-login auto.login.mac.-.another.account.mp4Smoke test has also been performed on both platforms on the following areas: [ ✔️ ] Log In/Log Out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR change?
Integrates the auto-login architecture. Shape
The implementation includes:
/{userAppData}/DecentralandLauncherLight/auth-token-bridge.txt(depending on the platform).Additionally, due to cyclic dependencies, all of the authenticator implementations have been moved into a new asmref.
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.