Skip to content

Conversation

@lorenzo-ranciaffi
Copy link
Contributor

Pull Request Description

Fixes #5682

What does this PR change?

This PR simplifies the chat title bar hierarchy by removing all content size fitter and managing everything by layouts. On top of that, few tweaks were needed to restore the button in order to interact with entity of the conversation (community or user)

Test Instructions

Test Steps

  1. Verify that the repro steps in the linked issue are now fixed
  2. Check all possible interaction with the chat title bar (context menus, voice calls, etc...) and that it always behaves as normal
  3. Check that the title bar behaves normally even with long user/community names

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review October 8, 2025 13:04
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners October 8, 2025 13:05
@lorenzo-ranciaffi lorenzo-ranciaffi moved this from Todo to With QA / Awaiting Review in Explorer Alpha Oct 8, 2025
Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Review has more weight in this one

@lorenzo-ranciaffi lorenzo-ranciaffi enabled auto-merge (squash) October 9, 2025 12:40
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve — Verified on Windows and Mac.
The main issue is fixed and the chat title bar works as expected.
I’ll create a separate ticket for the button state (hover color not persisting on click) so we can handle that improvement separately.

capture_251008_150628 capture_251008_150619

@github-project-automation github-project-automation bot moved this from With QA / Awaiting Review to In Progress in Explorer Alpha Oct 9, 2025
@lorenzo-ranciaffi lorenzo-ranciaffi merged commit a00d830 into dev Oct 9, 2025
13 of 16 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the fix/5682-chat-titlebar-button branch October 9, 2025 13:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in Explorer Alpha Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[QA] Chat | Hover menu missing in chat title bar

4 participants