pkg/watch: remove unused IsWindowsShortReadError #13052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was added in b3615d6 but appears to be unused. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Jul 16, 2025
| "strconv" | ||
|
|
||
| "github.com/tilt-dev/fsnotify" |
There was a problem hiding this comment.
I think I started looking at this to see if we still needed this fork; some of the reasons it was needed for were no longer there (upstream merged some fixes), but I don't know where I left off 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added in b3615d6 but appears to be unused.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did