Skip to content

pkg/watch: remove unused IsWindowsShortReadError #13052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −8
Open

pkg/watch: remove unused IsWindowsShortReadError #13052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pkg/watch/notify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,11 @@
package watch

import (
"errors"
"expvar"
"fmt"
"os"
"path/filepath"
"runtime"
"strconv"

"github.com/tilt-dev/fsnotify"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I started looking at this to see if we still needed this fork; some of the reasons it was needed for were no longer there (upstream merged some fixes), but I don't know where I left off 😂

)

var numberOfWatches = expvar.NewInt("watch.naive.numberOfWatches")
Expand Down Expand Up @@ -103,10 +99,6 @@ func DesiredWindowsBufferSize() int {
return defaultBufferSize
}

func IsWindowsShortReadError(err error) bool {
return runtime.GOOS == "windows" && !errors.Is(err, fsnotify.ErrEventOverflow)
}

type CompositePathMatcher struct {
Matchers []PathMatcher
}
Expand Down
Loading