Enable SSEv2 #382
Open
Enable SSEv2 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
andmat900 and
fredjn
and removed request for
a team
Configure RabbitMQ messagebus to support streams Add a new environment variable for stream port Add the key service deployment required by SSEv2 Add public key and private key configuration options
t-persson
force-pushed
the
enable-ssev2
branch
from
2749eaa to
1c6b6c0
Compare
Change-Id: I45f202c7f79e8995dab0906420b86a8dbd59ed0f
andmat900
reviewed
Oct 30, 2025
Contributor
andmat900
left a comment
andmat900
left a comment
There was a problem hiding this comment.
Is SSEv1 affected by this change? If so how?
| Image `json:",inline"` | ||
| // TODO: ETOS should be able to generate these if not set. | ||
| // +optional | ||
| PublicKey *VarSource `json:"publicKey,omitempty"` |
Contributor
There was a problem hiding this comment.
If the keypair is not set, shall it be generated by the controller?
Contributor
There was a problem hiding this comment.
I had some (unfinished) code for keypair generation, if it helps: https://github.com/andmat900/etos/blob/d62a874c7424ae5ca1e79ca1e161ee6c9ce13429/internal/etos/api/keys.go#L63
Collaborator
Author
It is not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
Configure RabbitMQ messagebus to support streams
Add a new environment variable for stream port
Add the key service deployment required by SSEv2
Add public key and private key configuration options
Alternate Designs
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]