Skip to content

Conversation

hellqvio86
Copy link

@hellqvio86 hellqvio86 commented Sep 19, 2025

Pagnination does not work, elastic-agnet goes rampid and makes way to many requests against the 1password api. Pagination should be same as the other streams.

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • [-] I have added an entry to my package's changelog.yml file.
  • [-] I have verified that Kibana version constraints are current according to guidelines.
  • [-] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Pagnination does not work, elastic-agnet goes rampid and makes way to many requests against the 1password api. Pagination should be same as the other streams.
@hellqvio86 hellqvio86 requested a review from a team as a code owner September 19, 2025 11:08
Copy link

cla-checker-service bot commented Sep 19, 2025

💚 CLA has been signed

@andrewkroh andrewkroh added Integration:1password 1Password (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 19, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me! However, I think one more change is required in order to keep the system tests working.

Now that the has_more controls the pagination, in this mock response, has_more value should be true so the test makes the second request and ingest the two expected events.

@chemamartinez
Copy link
Contributor

@hellqvio86 also the integration's version should be increased (to 1.33.1) and a changelog entry is required.

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version needs to be updated in the package manifest as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:1password 1Password (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants