Skip to content

Fix pagination in 1Password Audit collection #15407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
+6 −1
Open

Fix pagination in 1Password Audit collection #15407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b0d8b61
Fix pagination in 1Password Audit collection
hellqvio86 Sep 19, 2025
789b56e
Merge branch 'main' into patch-1
hellqvio86 Sep 19, 2025
97c26e3
Merge branch 'main' into patch-1
hellqvio86 Sep 19, 2025
b742bef
Merge branch 'main' into patch-1
hellqvio86 Sep 22, 2025
92a51a5
Merge branch 'main' into patch-1
hellqvio86 Sep 22, 2025
beb7a4c
Merge branch 'main' into patch-1
hellqvio86 Sep 23, 2025
e012219
Merge branch 'main' into patch-1
hellqvio86 Sep 24, 2025
d621b43
Adding change to changelog
hellqvio86 Sep 24, 2025
4525985
Setting flag to true
hellqvio86 Sep 24, 2025
508cd43
Merge branch 'main' into patch-1
hellqvio86 Sep 24, 2025
5b92baa
Merge branch 'main' into patch-1
hellqvio86 Sep 25, 2025
c758796
Apply suggestions from code review
hellqvio86 Sep 25, 2025
d096d33
Merge branch 'main' into patch-1
hellqvio86 Sep 25, 2025
6c16edc
Merge branch 'main' into patch-1
hellqvio86 Sep 25, 2025
4b4d745
Merge branch 'main' into patch-1
hellqvio86 Sep 25, 2025
d83976a
Merge branch 'main' into patch-1
hellqvio86 Sep 26, 2025
70230f6
Merge branch 'main' into patch-1
hellqvio86 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/1password/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.34.1"
changes:
- description: Fix for pagination for 1Password audit events
type: bugfix
link: https://github.com/elastic/integrations/pull/15407
- version: "1.34.0"
changes:
- description: Prevent updating fleet health status to degraded.
Expand Down
2 changes: 1 addition & 1 deletion packages/1password/data_stream/audit_events/agent/stream/httpjson.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ response.split:
response.pagination:
- set:
target: body.cursor
value: '[[if eq .last_response.body.has_more true]][[.last_response.body.cursor]][[end]]'
value: '[[if eq .last_response.body.has_more true]][[.last_response.body.cursor]][[else]][[/*This is an empty value to stop pagination.*/]][[end]]'
fail_on_template_error: true
do_not_log_failure: true
- delete:
Expand Down