opcm: Add support for V2 contracts in addGameType #17782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17782 +/- ##
===========================================
+ Coverage 74.79% 81.37% +6.58%
===========================================
Files 175 120 -55
Lines 11243 6475 -4768
===========================================
- Hits 8409 5269 -3140
+ Misses 2690 1206 -1484
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
10acbd8 to
c68aaad
Compare
mbaxter
reviewed
Oct 14, 2025
Base automatically changed from
snevin/issue-17257/creator-pattern-opcm-deploy
to
develop
October 14, 2025 18:04
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
2164a91 to
bd8fe5b
Compare
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
38bd133 to
ae95105
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/contracts-bedrock/snapshots/abi/OPContractsManagerGameTypeAdder.json
Show resolved
Hide resolved
mbaxter
approved these changes
Oct 17, 2025
ajsutton
force-pushed
the
aj/game-type-as-arg
branch
from
7e73936 to
2cfe9a3
Compare
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
b1806eb to
b7eeaf6
Compare
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
cfbb1f0 to
3b1da5b
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
|
Back to draft until #17874 is merged - there's some extra commits from develop being pulled in here because of the various rebases. Will be easier to sort out when the parent is rebased on develop and merged. |
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
2 times, most recently
from
eabcf5a to
56a3217
Compare
smartcontracts
approved these changes
Oct 21, 2025
mbaxter
approved these changes
Oct 21, 2025
Tests failing when V2 is enabled because the expected L2 chain ID is loaded incorrectly.
…proxy and initialising correctly.
ajsutton
force-pushed
the
aj/creator-opcm-addGameType-rebuild
branch
from
56a3217 to
761f7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #17464 (by stealing all its changes as a starting point). Rebased on latest changes in #17408
Tests
Enabled the addGameType tests when run with v2 feature enabled.
Metadata
Fixes #17260