feat: deployment backend prototype based on Nelm #594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lesikov <[email protected]>
ldmonster
reviewed
Apr 25, 2025
yalosev
reviewed
Apr 25, 2025
yalosev
reviewed
Apr 25, 2025
yalosev
reviewed
Apr 25, 2025
yalosev
reviewed
Apr 25, 2025
Signed-off-by: Ilya Lesikov <[email protected]>
Signed-off-by: Ilya Lesikov <[email protected]>
ilya-lesikov
force-pushed
the
feat/nelm-backend-prototype
branch
from
fb27c74 to
5a940c3
Compare
This was referenced Jun 4, 2025
yalosev
reviewed
Jun 10, 2025
| } | ||
| } | ||
|
|
||
| return "", fmt.Errorf("moduleChecksum label not found in nelm release %q", releaseName) |
There was a problem hiding this comment.
Suggested change
| return "", fmt.Errorf("moduleChecksum label not found in nelm release %q", releaseName) | |
| return "", fmt.Errorf("moduleChecksum annotation not found in nelm release %q", releaseName) |
There was a problem hiding this comment.
This was actually my mistake above, we should've grabbed labels, not release annotations.
…Nelm Signed-off-by: Ilya Lesikov <[email protected]>
Signed-off-by: Ilya Lesikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.