-
Notifications
You must be signed in to change notification settings - Fork 356
feat(Reversible Eletrical Robot with proppeler): Created a Pluggin fo… #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gz-sim7
Are you sure you want to change the base?
Conversation
|
@andre-rebelo-teixeira I'll rework this to fit into the existing multicopter model. I'll come back by the end of the day |
82070e1 to
9b5b8cd
Compare
|
@mjcarroll now ready to review |
|
I think you mean to target this to There are also some minor linter issues picked up by CI, e.g. trailing whitespaces and possibly line width limit exceeding 80 chars. after a quick look through this PR, I think this shouldn't break existing behavior, is that correct? |
|
Hi @iche033 , it shouldn't no. We are doing a few more functional tests and then I'll fix the missing CI bits. |
b9e68c2 to
71b775d
Compare
Signed-off-by: Pedro-Roque <[email protected]>
71b775d to
6013fc4
Compare
|
@Pedro-Roque, any progress on this? #2791 (comment) about targeting the |
…r a reversible eletrical motor
Please beware this pluggin does not work by receiving as input the parameters of the mtor and proppeler, but rather the coeficients of a polinomial that converts from input singal (pwm) into thrust and torque exerted
New Feature
Some robots such as the one this plugin was created utilize a reversible electrical motor with a propeller attached, allowing the exertion of thrust in both directions, this was previously not modulated in any plugin so a new plugin was created capable of representing this behavior
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #
Summary
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
➡️ Forward port
Port <FROM_BRANCH> to <TO_BRANCH>
Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎈 Release
Preparation for <X.Y.Z> release.
Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>
Needed by <PR(s)>
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.