Fix crash when setting debug visualization mode while gi is disabled
#3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: momo <[email protected]>
|
@Mergifyio backport gz-sim10 gz-sim9 gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
This was referenced Sep 5, 2025
iche033
added a commit
that referenced
this pull request
Sep 5, 2025
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
iche033
added a commit
that referenced
this pull request
Sep 9, 2025
…3059) Signed-off-by: momo <[email protected]> Co-authored-by: Ian Chen <[email protected]> (cherry picked from commit 019e38c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3058
Summary
When attempting to set the debug visualization mode, the code now checks if
giis enabled. Ifgiis disabled, it logs an error and always sets the debug visualization mode toNoneto avoid a crash.Setting a debug visualization mode while
giis disabled can cause a crash due to invalid or released resources. This change ensures safety by forcing the mode to None whengiis not active.Checklist
codecheckpassed (See contributing)