Skip to content

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 5, 2025

🦟 Bug fix

Toward: #2945

Summary

The issues seems to stem form using iterators created on temporary std::string objects. Calling std::ostringstream::str creates a new string each time, so the begin and end calls are getting two different copies of the string. This PR instead just uses a single std::string object to construct the command line. This also wraps arguments with extra quotes if necessary. Lastly, it adds debug messages to help with QT6 library paths.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

The issues seems to stem form using iterators created on temporary
std::string objects.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR, I still see some intermittent failures in running gz sim or gz-sim-main . Still need to debug them but I agree that the PR should help.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 9, 2025
@azeey azeey merged commit 8edc447 into gazebosim:gz-sim10 Sep 9, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 9, 2025
@azeey azeey deleted the qt6_win branch September 9, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants