Run linter in deploy tool #417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Doing things in parallel looks good! I'll polish this up later |
thomasballinger
force-pushed
the
tom/linter
branch
from
acf0448 to
b3319df
Compare
thomasballinger
force-pushed
the
tom/linter
branch
from
b3319df to
45b4abf
Compare
thomasballinger
commented
Apr 20, 2025
| @@ -0,0 +1 @@ | |||
| ignore-workspace-root-check=true | |||
There was a problem hiding this comment.
allows installing libraries in the main chef project without warning (needed because now that this is a little pnpm monorepo)
| } from './messages'; | ||
| import { createScopedLogger } from '~/utils/logger'; | ||
|
|
||
| const logger = createScopedLogger('history'); |
There was a problem hiding this comment.
just cleanup so these aren't always printed
|
I'm not confident about linting not making things worse so I'll make another PR that's everything here except that. |
Merged
atrakh
pushed a commit
that referenced
this pull request
Apr 21, 2025
All the extra stuff I added in #417 without the linting
thomasballinger
force-pushed
the
tom/linter
branch
from
f9a362e to
be50c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run eslint in the deploy tool. This doesn't help much yet, but it adds a path for adding eslint rules specific to the failure modes we're seeing.
We'd try to catch things that have no type errors with these lint rules currently, since lint errors are only reported to the LLM if both typechecks fail. Alternately we could report eslint failures in addition to type errors.