Added setting CI Action and CI job id custom values on github action builds #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
requested changes
Jul 8, 2025
erichaagdev
reviewed
Jul 11, 2025
clayburn
reviewed
Jul 14, 2025
| addCustomValueAndSearchLink(develocity, "CI run", value)); | ||
| envVariable("GITHUB_HEAD_REF", providers).filter(value -> !value.isEmpty()).ifPresent(value -> | ||
| buildScan.value("PR branch", value)); | ||
| envVariable("GITHUB_ACTION", providers).ifPresent(value -> |
There was a problem hiding this comment.
Nitpick, but I'd group all of the env vars together that produce a value + link. In other words, I'd have the GITHUB_HEAD_REF logic last in this code block.
… improved code grouping
ribafish
force-pushed
the
gk/expandGhaValues
branch
from
dbe67b5 to
443dd19
Compare
clayburn
approved these changes
Jul 16, 2025
erichaagdev
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting CI Action and CI job id custom values on github action builds. This is an example GHA builds (the
buildscan), with the scan having two custom values (and search links) added: CI job id and CI step id. This will be helpful when you've got multiple builds running consecutively and are passing in arguments that affect those builds, but are not captured in a build scan (best example are Maven profiles for CCUD Maven).When this is accepted I will do the same for CCUD Maven (and sbt).
Closes #389.