Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/gradle/CustomBuildScanEnhancements.java
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,12 @@ public void execute(BuildResultAdapter buildResult) {
addCustomValueAndSearchLink(develocity, "CI workflow", value));
envVariable("GITHUB_RUN_ID", providers).ifPresent(value ->
addCustomValueAndSearchLink(develocity, "CI run", value));
envVariable("GITHUB_ACTION", providers).ifPresent(value ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but I'd group all of the env vars together that produce a value + link. In other words, I'd have the GITHUB_HEAD_REF logic last in this code block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayburn done

addCustomValueAndSearchLink(develocity, "CI step", value));
envVariable("GITHUB_JOB", providers).ifPresent(value ->
addCustomValueAndSearchLink(develocity, "CI job", value));
envVariable("GITHUB_HEAD_REF", providers).filter(value -> !value.isEmpty()).ifPresent(value ->
buildScan.value("PR branch", value));
buildScan.value("PR branch", value));
}

if (isGitLab(providers)) {
Expand Down
Loading