Skip to content

Conversation

@kellyguo11
Copy link
Contributor

Description

Adds a couple of robots that were missing from the init.py imports

Fixes #3881

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added bug Something isn't working asset New asset feature or request labels Nov 7, 2025
@kellyguo11 kellyguo11 moved this to In review in Isaac Lab Nov 7, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Added missing imports for three robot modules (agibot, agility, and cassie) to the __init__.py file, making their robot configurations (AGIBOT_A2D_CFG, DIGIT_V4_CFG, and CASSIE_CFG) accessible via direct import from isaaclab_assets.robots.

  • Added from .agibot import * to expose AGIBOT_A2D_CFG
  • Added from .agility import * to expose DIGIT_V4_CFG and related constants
  • Added from .cassie import * to expose CASSIE_CFG
  • All imports maintain alphabetical ordering consistent with existing pattern

The fix resolves issue #3881 where users were unable to import these robot configurations directly from the package.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it only adds missing module imports
  • The change is straightforward and low-risk: three wildcard imports were added to expose existing robot configuration modules that were already present in the codebase. The imports follow the existing alphabetical pattern, the referenced modules exist and contain valid exports, and the change directly resolves the reported issue without modifying any logic or functionality.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
source/isaaclab_assets/isaaclab_assets/robots/init.py 5/5 Added missing imports for agibot, agility, and cassie robot modules in alphabetical order

Sequence Diagram

sequenceDiagram
    participant User
    participant __init__.py
    participant agibot
    participant agility
    participant cassie
    
    User->>__init__.py: Import robot configs
    __init__.py->>agibot: from .agibot import *
    agibot-->>__init__.py: AGIBOT_A2D_CFG
    __init__.py->>agility: from .agility import *
    agility-->>__init__.py: DIGIT_V4_CFG, LEG_JOINT_NAMES, ARM_JOINT_NAMES
    __init__.py->>cassie: from .cassie import *
    cassie-->>__init__.py: CASSIE_CFG
    __init__.py-->>User: All robot configs available
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 11, 2025

Greptile Overview

Greptile Summary

This PR adds three missing wildcard imports to the robots package __init__.py file, exposing robot configurations (AGIBOT_A2D_CFG, DIGIT_V4_CFG, CASSIE_CFG) that were previously inaccessible via direct import from isaaclab_assets.robots.

Changes Made:

  • Added from .agibot import * - exposes AGIBOT_A2D_CFG humanoid robot configuration
  • Added from .agility import * - exposes DIGIT_V4_CFG robot configuration plus joint name constants
  • Added from .cassie import * - exposes CASSIE_CFG bipedal robot configuration

All imports are correctly positioned in alphabetical order, and the corresponding module files exist with valid Python syntax. This is a straightforward bug fix that resolves issue #3881.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes add three missing wildcard imports to expose robot configurations. All imported modules exist, contain valid Python code with proper exports, imports are in correct alphabetical order, and syntax is valid. This is a simple, well-tested bug fix with no logical complexity or potential side effects.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
source/isaaclab_assets/isaaclab_assets/robots/init.py 5/5 Added missing imports for agibot, agility, and cassie robot modules in correct alphabetical order

Sequence Diagram

sequenceDiagram
    participant User
    participant __init__.py
    participant agibot.py
    participant agility.py
    participant cassie.py

    User->>__init__.py: from isaaclab_assets.robots import CASSIE_CFG, AGIBOT_A2D_CFG, DIGIT_V4_CFG
    __init__.py->>agibot.py: from .agibot import *
    agibot.py-->>__init__.py: AGIBOT_A2D_CFG
    __init__.py->>agility.py: from .agility import *
    agility.py-->>__init__.py: DIGIT_V4_CFG, LEG_JOINT_NAMES, ARM_JOINT_NAMES
    __init__.py->>cassie.py: from .cassie import *
    cassie.py-->>__init__.py: CASSIE_CFG
    __init__.py-->>User: All configurations available
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asset New asset feature or request bug Something isn't working

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

[Bug Report] Missing robot imports

2 participants