-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adds missing robot imports #3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Added missing imports for three robot modules (agibot, agility, and cassie) to the __init__.py file, making their robot configurations (AGIBOT_A2D_CFG, DIGIT_V4_CFG, and CASSIE_CFG) accessible via direct import from isaaclab_assets.robots.
- Added
from .agibot import *to exposeAGIBOT_A2D_CFG - Added
from .agility import *to exposeDIGIT_V4_CFGand related constants - Added
from .cassie import *to exposeCASSIE_CFG - All imports maintain alphabetical ordering consistent with existing pattern
The fix resolves issue #3881 where users were unable to import these robot configurations directly from the package.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk - it only adds missing module imports
- The change is straightforward and low-risk: three wildcard imports were added to expose existing robot configuration modules that were already present in the codebase. The imports follow the existing alphabetical pattern, the referenced modules exist and contain valid exports, and the change directly resolves the reported issue without modifying any logic or functionality.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| source/isaaclab_assets/isaaclab_assets/robots/init.py | 5/5 | Added missing imports for agibot, agility, and cassie robot modules in alphabetical order |
Sequence Diagram
sequenceDiagram
participant User
participant __init__.py
participant agibot
participant agility
participant cassie
User->>__init__.py: Import robot configs
__init__.py->>agibot: from .agibot import *
agibot-->>__init__.py: AGIBOT_A2D_CFG
__init__.py->>agility: from .agility import *
agility-->>__init__.py: DIGIT_V4_CFG, LEG_JOINT_NAMES, ARM_JOINT_NAMES
__init__.py->>cassie: from .cassie import *
cassie-->>__init__.py: CASSIE_CFG
__init__.py-->>User: All robot configs available
1 file reviewed, no comments
Greptile OverviewGreptile SummaryThis PR adds three missing wildcard imports to the robots package Changes Made:
All imports are correctly positioned in alphabetical order, and the corresponding module files exist with valid Python syntax. This is a straightforward bug fix that resolves issue #3881. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant __init__.py
participant agibot.py
participant agility.py
participant cassie.py
User->>__init__.py: from isaaclab_assets.robots import CASSIE_CFG, AGIBOT_A2D_CFG, DIGIT_V4_CFG
__init__.py->>agibot.py: from .agibot import *
agibot.py-->>__init__.py: AGIBOT_A2D_CFG
__init__.py->>agility.py: from .agility import *
agility.py-->>__init__.py: DIGIT_V4_CFG, LEG_JOINT_NAMES, ARM_JOINT_NAMES
__init__.py->>cassie.py: from .cassie import *
cassie.py-->>__init__.py: CASSIE_CFG
__init__.py-->>User: All configurations available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Description
Adds a couple of robots that were missing from the init.py imports
Fixes #3881
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there