Skip to content

Remove explicit sysctl fs.inotify.max_user_watches setting #17556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

Remove explicit sysctl fs.inotify.max_user_watches setting #17556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions nodeup/pkg/model/sysctls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,10 @@ func (b *SysctlBuilder) Build(c *fi.NodeupModelBuilderContext) error {
"fs.file-max = 2097152",
"",

"# Max number of inotify instances and watches for a user",
"# Max number of inotify instances for a user",
"# Since dockerd runs as a single user, the default instances value of 128 per user is too low",
"# e.g. uses of inotify: nginx ingress controller, kubectl logs -f",
"fs.inotify.max_user_instances = 8192",
"fs.inotify.max_user_watches = 524288",

"# Additional sysctl flags that kubelet expects",
"vm.overcommit_memory = 1",
Expand Down
Loading