README.md fix LND version #1145
Conversation
The LiT to LND table is updated to match what is stated in - https://github.com/lightninglabs/lightning-terminal/releases/tag/v0.15.2-alpha - https://github.com/lightninglabs/lightning-terminal/releases/tag/v0.15.1-alpha - https://github.com/lightninglabs/lightning-terminal/releases/tag/v0.15.0-alpha
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the accuracy of the project's documentation. It updates specific version compatibility information within the README.md file, ensuring that users referencing the document have the most current and correct details regarding supported LND versions for various LiT releases.
Highlights
- README.md LND Version Update: The compatibility table in README.md has been updated to reflect the correct LND versions for LiT v0.15.2-alpha (now v0.19.3-beta), v0.15.1-alpha (now v0.19.2-beta), and v0.15.0-alpha (now v0.19.1-beta). This ensures the documentation aligns with the latest release information.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the LND version compatibility table in README.md for LiT versions v0.15.0-alpha through v0.15.2-alpha. The updated LND versions now correctly reflect the information from the release notes and the 'Daemon Versions packaged with LiT' table, resolving an inconsistency in the documentation. The change is accurate and improves the documentation for users. The changes look correct.
| | **v0.15.2-alpha** | v0.19.3-beta | | ||
| | **v0.15.1-alpha** | v0.19.2-beta | | ||
| | **v0.15.0-alpha** | v0.19.1-beta | |
There was a problem hiding this comment.
@ZZiigguurraatt, this can be a bit confusing when reading the README, but actually v0.19.0-beta is correct here as this details the minimum lnd version that's compatible with these litd versions, when running lnd in remote mode. This is described in the text above, but I agree that this can be a bit confusing :). This change is therefore not needed.
Perhaps this should be described in a more easy to understand way, to make this less confusing? If you think that's the case, feel free to change the PR to update how this information is displayed. Else, if you find the text above to be clear enough, I suggest we close the PR.
There was a problem hiding this comment.
OK, basically you are right I just failed to read.
However, for people who are just quickly skimming around, would it make more sense to put
Lines 171 to 231 in bce4c04
up first towards the top (before
Line 67 in bce4c04
and also change
Line 67 in bce4c04
to
"LND Version Compatibility When Used In Remote Mode"?
There was a problem hiding this comment.
Sure! That sounds like a great suggestion. Feel free to update the PR to update that instead :)
The LiT to LND table is updated to match what is stated in