-
Notifications
You must be signed in to change notification settings - Fork 107
README.md fix LND version #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZZiigguurraatt
wants to merge
1
commit into
lightninglabs:master
Choose a base branch
from
ZZiigguurraatt:readme_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZZiigguurraatt, this can be a bit confusing when reading the README, but actually
v0.19.0-betais correct here as this details theminimumlndversion that's compatible with theselitdversions, when runninglndin remote mode. This is described in the text above, but I agree that this can be a bit confusing :). This change is therefore not needed.Perhaps this should be described in a more easy to understand way, to make this less confusing? If you think that's the case, feel free to change the PR to update how this information is displayed. Else, if you find the text above to be clear enough, I suggest we close the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, basically you are right I just failed to read.
However, for people who are just quickly skimming around, would it make more sense to put
lightning-terminal/README.md
Lines 171 to 231 in bce4c04
up first towards the top (before
lightning-terminal/README.md
Line 67 in bce4c04
and also change
lightning-terminal/README.md
Line 67 in bce4c04
to
"LND Version Compatibility When Used In Remote Mode"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! That sounds like a great suggestion. Feel free to update the PR to update that instead :)