-
Notifications
You must be signed in to change notification settings - Fork 6
fix: project header items and menu UI on mobile view #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes mobile UI issues in the project header, improving responsive design for project navigation and layout elements. The changes focus on adjusting header items wrapping behavior and menu visibility across different screen sizes.
- Remove commented code and fix HTML structure in project menu
- Update responsive breakpoints and layout classes for project header elements
- Adjust container padding and flex layout for better mobile presentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
widget-area.vue | Remove container padding overrides to use default spacing |
project-menu.vue | Fix responsive visibility classes and clean up commented HTML |
header.vue | Restructure header layout with improved flex wrapping and responsive design |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
class="flex sm:items-center items-stretch min-w-0 max-w-full | ||
sm:flex-nowrap flex-wrap sm:w-auto w-full" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The class attribute spans multiple lines with inconsistent indentation. Consider formatting this as a single line or using consistent indentation for better readability.
class="flex sm:items-center items-stretch min-w-0 max-w-full | |
sm:flex-nowrap flex-wrap sm:w-auto w-full" | |
class="flex sm:items-center items-stretch min-w-0 max-w-full sm:flex-nowrap flex-wrap sm:w-auto w-full" |
Copilot uses AI. Check for mistakes.
@@ -93,7 +98,7 @@ SPDX-License-Identifier: MIT | |||
<lfx-button | |||
v-if="hasLfxInsightsPermission" | |||
type="tertiary" | |||
class="!rounded-full" | |||
class="!rounded-full !text-nowrap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using !text-nowrap
with the !
important modifier may cause specificity issues. Consider using whitespace-nowrap
instead, which is the standard Tailwind class for preventing text wrapping.
class="!rounded-full !text-nowrap" | |
class="!rounded-full whitespace-nowrap" |
Copilot uses AI. Check for mistakes.
In this PR
Ticket
IN-723