Skip to content

Conversation

emlimlf
Copy link
Collaborator

@emlimlf emlimlf commented Sep 16, 2025

In this PR

  • Fix the project tab menus on mobile
  • Adjust the project name and repository dropdown wrapping for different screen sizes

Ticket

IN-723

@emlimlf emlimlf requested review from Copilot and gaspergrom and removed request for Copilot September 16, 2025 02:35
@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 05:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes mobile UI issues in the project header, improving responsive design for project navigation and layout elements. The changes focus on adjusting header items wrapping behavior and menu visibility across different screen sizes.

  • Remove commented code and fix HTML structure in project menu
  • Update responsive breakpoints and layout classes for project header elements
  • Adjust container padding and flex layout for better mobile presentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
widget-area.vue Remove container padding overrides to use default spacing
project-menu.vue Fix responsive visibility classes and clean up commented HTML
header.vue Restructure header layout with improved flex wrapping and responsive design

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +20 to +21
class="flex sm:items-center items-stretch min-w-0 max-w-full
sm:flex-nowrap flex-wrap sm:w-auto w-full"
Copy link
Preview

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The class attribute spans multiple lines with inconsistent indentation. Consider formatting this as a single line or using consistent indentation for better readability.

Suggested change
class="flex sm:items-center items-stretch min-w-0 max-w-full
sm:flex-nowrap flex-wrap sm:w-auto w-full"
class="flex sm:items-center items-stretch min-w-0 max-w-full sm:flex-nowrap flex-wrap sm:w-auto w-full"

Copilot uses AI. Check for mistakes.

@@ -93,7 +98,7 @@ SPDX-License-Identifier: MIT
<lfx-button
v-if="hasLfxInsightsPermission"
type="tertiary"
class="!rounded-full"
class="!rounded-full !text-nowrap"
Copy link
Preview

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using !text-nowrap with the ! important modifier may cause specificity issues. Consider using whitespace-nowrap instead, which is the standard Tailwind class for preventing text wrapping.

Suggested change
class="!rounded-full !text-nowrap"
class="!rounded-full whitespace-nowrap"

Copilot uses AI. Check for mistakes.

@emlimlf emlimlf merged commit e7152cc into main Sep 16, 2025
9 checks passed
@emlimlf emlimlf deleted the fix/project-head-mobile branch September 16, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants