-
Notifications
You must be signed in to change notification settings - Fork 6
fix: project header items and menu UI on mobile view #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+38
−53
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,35 +15,40 @@ SPDX-License-Identifier: MIT | |||||
| class="ease-linear transition-all" | ||||||
| :class="scrollTop > 50 ? 'py-3 md:py-4' : 'py-3 md:py-6'" | ||||||
| > | ||||||
| <div class="flex items-center justify-between gap-2"> | ||||||
| <div class="flex items-center min-w-0"> | ||||||
| <lfx-back class="ease-linear transition-all pr-1 sm:pr-4"> | ||||||
| <lfx-icon-button | ||||||
| type="transparent" | ||||||
| icon="angle-left" | ||||||
| class="" | ||||||
| <div class="flex items-center flex-row justify-between gap-2 flex-wrap"> | ||||||
| <div | ||||||
| class="flex sm:items-center items-stretch min-w-0 max-w-full | ||||||
| sm:flex-nowrap flex-wrap sm:w-auto w-full" | ||||||
| > | ||||||
| <div class="flex items-center grow sm:max-w-none max-w-full"> | ||||||
| <lfx-back class="ease-linear transition-all pr-1 sm:pr-4"> | ||||||
| <lfx-icon-button | ||||||
| type="transparent" | ||||||
| icon="angle-left" | ||||||
| class="" | ||||||
| /> | ||||||
| </lfx-back> | ||||||
| <lfx-organization-logo | ||||||
| class="mr-4 max-h-8 md:max-h-12" | ||||||
| :src="props.project?.logo || ''" | ||||||
| :size="scrollTop > 50 ? 'normal' : ((pageWidth < 768 && pageWidth > 0) ? 'normal' : 'large')" | ||||||
| :is-lf="!!props.project?.isLF" | ||||||
| /> | ||||||
| </lfx-back> | ||||||
| <lfx-organization-logo | ||||||
| class="mr-4 max-h-8 md:max-h-12" | ||||||
| :src="props.project?.logo || ''" | ||||||
| :size="scrollTop > 50 ? 'normal' : ((pageWidth < 768 && pageWidth > 0) ? 'normal' : 'large')" | ||||||
| :is-lf="!!props.project?.isLF" | ||||||
| /> | ||||||
|
|
||||||
| <h1 | ||||||
| class="font-bold mr-3 ease-linear transition-all | ||||||
| font-secondary duration-200 text-heading-4 line-clamp-1 max-w-[25ch] truncate" | ||||||
| :class="[ | ||||||
| scrollTop > 50 ? 'md:text-heading-3' : 'md:text-heading-2' | ||||||
| ]" | ||||||
| > | ||||||
| {{ props.project?.name }} | ||||||
| </h1> | ||||||
| <span | ||||||
| v-if="(props.project?.repositories?.length ?? 0) > 0" | ||||||
| class="mr-1 text-neutral-400 font-secondary leading-8 ease-linear transition-all text-2xl" | ||||||
| >/</span> | ||||||
| <h1 | ||||||
| class="font-bold mr-3 ease-linear transition-all | ||||||
| font-secondary duration-200 text-heading-4 line-clamp-1 sm:max-w-[25ch] truncate" | ||||||
| :class="[ | ||||||
| scrollTop > 50 ? 'md:text-heading-3' : 'md:text-heading-2' | ||||||
| ]" | ||||||
| > | ||||||
| {{ props.project?.name }} | ||||||
| </h1> | ||||||
| <span | ||||||
| v-if="(props.project?.repositories?.length ?? 0) > 0" | ||||||
| class="mr-1 text-neutral-400 font-secondary leading-8 ease-linear transition-all text-2xl" | ||||||
| >/</span> | ||||||
| </div> | ||||||
| <div | ||||||
| v-if="(props.project?.repositories?.length ?? 0) > 0" | ||||||
| class="flex items-center gap-3 cursor-pointer px-2 py-0.5 | ||||||
|
|
@@ -76,7 +81,7 @@ SPDX-License-Identifier: MIT | |||||
| /> | ||||||
| </div> | ||||||
| </div> | ||||||
| <div class="hidden sm:flex items-center gap-4"> | ||||||
| <div class="hidden sm:flex items-center gap-4 flex-grow justify-end"> | ||||||
| <lfx-icon-button | ||||||
| icon="comment-exclamation" | ||||||
| size="medium" | ||||||
|
|
@@ -93,7 +98,7 @@ SPDX-License-Identifier: MIT | |||||
| <lfx-button | ||||||
| v-if="hasLfxInsightsPermission" | ||||||
| type="tertiary" | ||||||
| class="!rounded-full" | ||||||
| class="!rounded-full !text-nowrap" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| @click="openCopilotHandler()" | ||||||
| > | ||||||
| <lfx-icon name="sparkles" /> | ||||||
|
|
@@ -145,18 +150,6 @@ SPDX-License-Identifier: MIT | |||||
| /> | ||||||
| <p class="text-xs whitespace-nowrap">Report issue</p> | ||||||
| </div> | ||||||
| <div | ||||||
| v-if="hasLfxInsightsPermission" | ||||||
| class="flex items-center py-1.5 px-3 gap-1.5 cursor-pointer" | ||||||
| @click="openCopilotHandler()" | ||||||
| > | ||||||
| <lfx-icon | ||||||
| name="sparkles" | ||||||
| :size="14" | ||||||
| class="text-brand-500" | ||||||
| /> | ||||||
| <p class="text-xs whitespace-nowrap">Ask Copilot</p> | ||||||
| </div> | ||||||
| </div> | ||||||
| </teleport> | ||||||
| <lfx-project-date-range-picker | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The class attribute spans multiple lines with inconsistent indentation. Consider formatting this as a single line or using consistent indentation for better readability.
Copilot uses AI. Check for mistakes.