Metal: Port existing and extend new Metal 4 no-unsafe annotations
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
from
72ab5d5 to
35cb0d1
Compare
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
from
35cb0d1 to
09f0a25
Compare
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
from
09f0a25 to
d987ab0
Compare
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
from
b927e7f to
7e98970
Compare
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
2 times, most recently
from
3141e21 to
209eb22
Compare
The new `Metal4` types inherit a lot of functions from older Metal versions that need to be annotated to not be unsafe, so that they can be more trivially called.
MarijnS95
force-pushed
the
xcode-26-metal-unsafe
branch
from
209eb22 to
7e1e327
Compare
|
We'll handle the majority of this in #792, so I'll close this in favour of that. |
|
I'll try to amend the missing bits into #773, which you left open and where the majority of the safety aspects remain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #762 (probably postponing this until that's merged)
Depends on #772, #773
See #773 for more details. We should resolve things there first before considering this PR, but I'm opening it already for completeness (and because it's very useful in my daily work on Metal 4) nevertheless.
The new
MTL4types inherit a lot of functions from older Metal versions that need to be annotated to not be unsafe, so that they can be more trivially called.