fix(compat-table): show message when JavaScript is disabled #890
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
commented
Oct 10, 2025
danielhjacobs
force-pushed
the
show-error-when-js-disabled
branch
6 times, most recently
from
72df6f3 to
202b798
Compare
danielhjacobs
force-pushed
the
show-error-when-js-disabled
branch
from
202b798 to
9a21f2c
Compare
danielhjacobs
changed the title
caugner
reviewed
Oct 15, 2025
|
Added comments regarding unaddressed review notes to document why I did not address them. |
|
Addressed the review comments, removing the CSS and the prettier ignore directive. As noted in one of the review threads, I don't think this component ever actually enters the pending state, seemingly going straight from initial to complete. I guess maybe that's fine, but it does mean the Loading... message seems to no longer appear as the page first loads. |
caugner
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #873
Motivation
So if JS is disabled there is a message
JS enabled (same as current):
Screencast.From.2025-10-10.09-46-15.mp4
JS disabled: