Skip to content

fix(compat-table): show message when JavaScript is disabled #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(compat-table): show message when JavaScript is disabled #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53dfd08
Show a message that JS is required when disabled for BCD
danielhjacobs Oct 8, 2025
9a21f2c
Don't let prettier reformat template literal
danielhjacobs Oct 10, 2025
c0e003a
fix(compat-table): address review comments
danielhjacobs Oct 15, 2025
4477283
fix(compat-table): address latest review comments
danielhjacobs Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/compat-table-lazy/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Task } from "@lit/task";
import { LitElement, html } from "lit";
import { unsafeHTML } from "lit/directives/unsafe-html.js";

import "../compat-table/element.js";
import { L10nMixin } from "../../l10n/mixin.js";
Expand Down Expand Up @@ -95,8 +96,11 @@ export class MDNCompatTableLazy extends L10nMixin(LitElement) {
});

render() {
const noScript = unsafeHTML(
`<noscript>${this.l10n("compat-js-required")`Enable JavaScript to view this browser compatibility table.`}</noscript>`,
);
return this._dataTask.render({
initial: () => html`<p>${this.l10n("compat-loading")`Loading…`}</p>`,
initial: () => html`<p>${noScript}</p>`,
pending: () => html`<p>${this.l10n("compat-loading")`Loading…`}</p>`,

complete:
Expand Down
1 change: 1 addition & 0 deletions l10n/en-US.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ obs-mdn = The { -brand-name-obs } provides effective security insights, guided b


compat-loading = Loading…
compat-js-required = Enable JavaScript to view this browser compatibility table.

compat-browser-version-date = { $browser } { $version } – Release date: { $date }
compat-browser-version-released = Release date: { $date }
Expand Down