Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested these changes on my fork repo and all workflows pass.
The changes:
cargo wasirepo is archived and the recent change by the rust project to rename the wasm32-wasi target to wasm32-wasip1 has brokencargo wasias it is stuck using the now nonexistantwasm32-wasitarget. While this whole thing is very silly and could probably be resolved by forkingcargo-wasmand changing the name of the target, since upstream is so broken, I dont think theres much point in maintaining the CI forcargo-wasm/wasm32-wasip1. The future seems to be incargo-component/wasm32-wasp2, so any future work on CI should be done to use that. However, I could not find an easy to run tests withcargo-componentso I'm thinking its best to just disable the existingwasm32-wasip1workflow and let someone with more wasm experience come along and fix it.