Skip to content

ODSP Client new exposed functionality (DO NOT MERGE) #25597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ODSP Client new exposed functionality (DO NOT MERGE) #25597

wants to merge 4 commits into from

Conversation

znewton
Copy link
Contributor

@znewton znewton commented Oct 2, 2025 •
edited
Loading

Description

There are several API functionalities that need to be exposed by ODSP Client for consumer use. However, they will all involve separate API reviews. This is just to get them all in 1 place and compiling.

To be broken down later.

Breaking Changes

Yes

Reviewer Guidance

This will be split up, don't panic.

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct dependencies Pull requests that update a dependency file public api change Changes to a public API base: main PRs targeted against main branch labels Oct 2, 2025
@znewton znewton changed the title Copy over ODSP changes from Designer to FF ODSP Client new exposed functionality (DO NOT MERGE) Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@znewton znewton mentioned this pull request Oct 8, 2025
Merged
znewton added a commit that referenced this pull request Oct 9, 2025
@znewton
refactor(odsp-client): Move ODSP Container Services into a class (#25646
5f52833 
)

## Description

This PR moves ODSP Container Services into a `class` implementation to
prepare for changes coming out of #25597.

## Reviewer Guidance

This PR seems pointless on the surface, but it will make life
significantly easier when asynchronously adding various functionality to
the ODSP Container Services, some of which use class/extension syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@znewton