Skip to content

Bugfix FXIOS-13543 ⁃ [iOS 26][iPad] Tab name bar color differs from the rest of the toolbar #29869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2025
Merged

Bugfix FXIOS-13543 ⁃ [iOS 26][iPad] Tab name bar color differs from the rest of the toolbar #29869

merged 3 commits into from
Oct 13, 2025

Conversation

@dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added .clear background

🎥 Demos

Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-10-07 at 15 42 10 Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-10-07 at 16 32 27
Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@dicarobinho dicarobinho marked this pull request as ready for review October 7, 2025 13:41
@dicarobinho dicarobinho requested a review from a team as a code owner October 7, 2025 13:42
@dicarobinho dicarobinho closed this Oct 7, 2025
@dicarobinho dicarobinho reopened this Oct 7, 2025
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 7, 2025 •
edited
Loading

Messages
📖 Project coverage: 38.31%

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.26

File Coverage
TopTabsViewController.swift 24.25% ⚠️
TopTabCell.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 8c1204e

@dicarobinho dicarobinho merged commit 891a301 into main Oct 13, 2025
8 of 9 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_13543_29439_top_tabs_color branch October 13, 2025 08:30
@github-actions
Copy link
Contributor

🚀 PR merged to main, targeting version: 144.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dicarobinho @mobiletest-ci-bot @thatswinnie