Skip to content

Bugfix FXIOS-13543 ⁃ [iOS 26][iPad] Tab name bar color differs from the rest of the toolbar #29869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

Bugfix FXIOS-13543 ⁃ [iOS 26][iPad] Tab name bar color differs from the rest of the toolbar #29869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40f519a
FXIOS-13543 #29439 ⁃ [iOS 26][iPad] Tab name bar color differs from t…
dicarobinho Oct 7, 2025
c404727
Merge branch 'main' into afarcasanu/fxios_13543_29439_top_tabs_color
dicarobinho Oct 8, 2025
8c1204e
Set clear background for view
dicarobinho Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions firefox-ios/Client/Frontend/Browser/TopTabCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,7 @@ class TopTabCell: UICollectionViewCell, ThemeApplicable, ReusableCell, FeatureFl
titleText.textColor = colors.textPrimary
closeButton.tintColor = colors.textPrimary

if let toolbarState = store.state.screenState(ToolbarState.self, for: .toolbar, window: windowUUID),
toolbarState.isTranslucent {
cellBackground.backgroundColor = toolbarState.isTranslucent ? .clear : colors.actionTabInactive
} else {
cellBackground.backgroundColor = colors.actionTabInactive
}

cellBackground.backgroundColor = .clear
cellBackground.layer.shadowColor = UIColor.clear.cgColor
cellBackground.isHidden = false
}
Expand Down
3 changes: 1 addition & 2 deletions firefox-ios/Client/Frontend/Browser/TopTabsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,11 @@ class TopTabsViewController: UIViewController, Themeable, Notifiable, FeatureFla
let currentTheme = themeManager.getCurrentTheme(for: windowUUID)
let colors = currentTheme.colors

view.backgroundColor = .clear
if let toolbarState = store.state.screenState(ToolbarState.self, for: .toolbar, window: windowUUID),
toolbarState.isTranslucent {
view.backgroundColor = colors.layerSurfaceLow.withAlphaComponent(toolbarHelper.backgroundAlpha())
collectionView.backgroundColor = .clear
} else {
view.backgroundColor = colors.layer3
collectionView.backgroundColor = view.backgroundColor
}

Expand Down
Loading