Skip to content

[DataGrid] Fix cell not rerendering on isCellEditable prop change #19898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

[DataGrid] Fix cell not rerendering on isCellEditable prop change #19898

merged 5 commits into from
Oct 13, 2025

Conversation

@cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Oct 10, 2025 •
edited
Loading

@cherniavskii cherniavskii added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. feature: Editing Related to the data grid Editing feature labels Oct 10, 2025
@mui-bot
Copy link

mui-bot commented Oct 10, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19898--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+131B(+0.03%) 🔺+27B(+0.02%)
@mui/x-data-grid-pro 🔺+131B(+0.03%) 🔺+27B(+0.02%)
@mui/x-data-grid-premium 🔺+131B(+0.02%) 🔺+25B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against c64771d

@cherniavskii cherniavskii marked this pull request as ready for review October 10, 2025 15:48
@cherniavskii cherniavskii mentioned this pull request Oct 10, 2025
Closed
romgrk
romgrk reviewed Oct 10, 2025
View reviewed changes
@cherniavskii cherniavskii force-pushed the rerender-cell-on-isCellEditable-change branch from 1c8734e to 33e2635 Compare October 13, 2025 12:00
@cherniavskii cherniavskii merged commit 7d7d64b into mui:master Oct 13, 2025
21 checks passed
@cherniavskii cherniavskii deleted the rerender-cell-on-isCellEditable-change branch October 13, 2025 16:24
@arminmeh arminmeh mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romgrk romgrk romgrk approved these changes

Assignees

No one assigned

Labels

feature: Editing Related to the data grid Editing feature scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] isCellEditable callback contains stale data from the outer scope

3 participants

@cherniavskii @mui-bot @romgrk