chore(netwatch): Update n0-watcher dependency
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/31/docs/net_tools/ Last updated: 2025-07-25T09:41:16Z |
dignifiedquire
approved these changes
Jul 25, 2025
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Jul 28, 2025
## Description Updates the `n0-watcher` dependency to the new version (that has a lot fewer `Result`s everywhere). - [x] Depends on n0-computer/net-tools#31 - [x] Needs a release of `net-tools` ## Breaking Changes - Updated `n0-watcher` from version `0.2` to `0.3`. Migration guide for users: - `endpoint.node_addr().initialized().await?` -> `endpoint.node_addr().initialized().await` (no `?` needed anymore) and similarly for `endpoint.home_relay()` and other uses of `Watcher`s. - `endpoint.node_addr().get()?` -> `endpoint.node_addr().get()` and similarly for `endpoint.home_relay()` and other uses of `Watcher`s. - If all you have is a `&impl Watcher` but you need the current value, then you can't call `Watcher::get` anymore, as that now takes a `&mut self` instead of `&self`. You can work around this by `.clone()`ing to an intermediate watcher: `watcher_ref.get()` -> `watcher_ref.clone().get()` ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
n0-watcherto v0.3Breaking Changes
netwatch::netmon::Monitor::interface_statenow returns aWatcherfrom the newn0-watchercrate version. You can.get()its value without anotherResult.Change checklist