Skip to content

Conversation

@FriederikeHanssen
Copy link
Contributor

Refactoring code to adhere to the language server

WIP:

  • config if/else statements: I assume we need a lot of closers in the publishDir if that is possible
  • Several modules need updating upstream
  • still need to address warnings

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@maxulysse maxulysse added this to the 3.6 milestone Jun 24, 2025
@famosab famosab mentioned this pull request Jul 14, 2025
11 tasks

withName: 'NFCORE_SAREK:SAREK:FASTQ_ALIGN_GATK:CRAM_TO_BAM' {
ext.when = { params.save_output_as_bam }
// TODO how to handle this properly?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta map?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ie:

ext.prefix = { "${meta.id}.${meta.prefix}" }

and:

path: { "${params.outdir}/preprocessing/${meta.publish_path}/${meta.id}/" },

}
}

//TODO this needs to be removed/moved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be removed

Comment on lines 20 to 22
if (params.use_gatk_spark) {
containerOptions = ''
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this with the profile spark?

@FriederikeHanssen FriederikeHanssen removed this from the 3.6 milestone Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants