-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docker-cli: add docker contexts support #7891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8bc86cf to
f13cb7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@will-lol Each docker context must have a unique name right? If yes, I wonder if it might be better if the context name would be used as a key. E.g.: How many options can be set, inside a context? Is the number limited? If yes, we could consider adding them all as options. |
|
Hey @FriedrichAltheide. I can't for the life of me find any schema or actual helpful documentation about docker contexts. So I'm honestly not sure what can be set now, or how that will change in the future. I think to reduce our maintenance burden, it would be better to leave as json format. |
f13cb7c to
70bf4a7
Compare
|
@FriedrichAltheide I have switched to using an attrset as per your advice: It supports the Name attribute as well if it is specified. |
70bf4a7 to
d504090
Compare
|
sorry, can you rebase to fix ci issue |
d504090 to
06bcccd
Compare
24729e9 to
820bfe6
Compare
Adds docker-cli.contexts support. This allows declarative configuration of [docker contexts](https://docs.docker.com/engine/manage-resources/contexts/).
820bfe6 to
4b05f87
Compare
Description
Adds docker-cli.contexts support. This allows declarative configuration of docker contexts.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.